RebeccaNod1
dd03bd8eef
🧠 MEMORY OPTIMIZATION & DEAD CODE CLEANUP: - Removed vestigial UpdateHelper.lsl (204 lines, ~41KB memory waste) - Main Controller memory improved from 83.8% to 81.4% (2.4% reduction) - Simplified Verbose_Logger from 149 to 80 lines (47% reduction) - Eliminated unused buffering systems and timer overhead 🎨 BOT PROFILE PICTURE FIX: - Fixed bot avatars randomly turning into gray boxes mid-game - Modified refreshPlayerDisplay() to preserve active player textures - Enhanced bot caching to prevent HTTP requests - Stable bot visuals throughout entire game 🏗️ ARCHITECTURE OPTIMIZATION: - Updated link numbers: Scoreboard (2→12), Leaderboard (25→35), Dice (73→83) - Enhanced prim structure with dedicated overlay prims (links 2-11) - Updated 11 scripts with new mappings and prim ranges - More organized and scalable linkset structure 🔧 ENHANCED GAME LOGIC & BUG FIXES: - Improved number picker parsing for CSV and semicolon formats - Enhanced bot round detection and fair play mechanics - Better communication handling and player feedback - Whitespace handling for consistent number parsing 📊 PERFORMANCE IMPACT: - Measurable memory reduction across multiple scripts - Eliminated profile picture flickering and display issues - Reduced unnecessary inter-script message traffic - Cleaner, more maintainable codebase Files changed: 11 modified scripts, 4 updated documentation files Total: 838 insertions, 776 deletions representing significant optimization
426 lines
No EOL
17 KiB
Text
426 lines
No EOL
17 KiB
Text
// === Dialog Handler (Updated for Peril Dice - Paginated Multiple Picks) ===
|
|
|
|
integer MSG_SHOW_DIALOG = 101;
|
|
integer MSG_GET_CURRENT_DIALOG = 302;
|
|
|
|
// Verbose logging control
|
|
integer VERBOSE_LOGGING = TRUE; // Global flag for verbose debug logs
|
|
integer MSG_TOGGLE_VERBOSE_LOGS = 9998; // Message to toggle verbose logging
|
|
|
|
// =============================================================================
|
|
// DYNAMIC CHANNEL CONFIGURATION
|
|
// =============================================================================
|
|
|
|
// Base channel offset - should match Main.lsl
|
|
integer CHANNEL_BASE = -77000;
|
|
|
|
// Calculate channels dynamically to avoid hardcoded conflicts
|
|
integer calculateChannel(integer offset) {
|
|
// Use BOTH owner's key AND object's key to make channels unique per game instance
|
|
// This prevents interference when same owner has multiple game tables
|
|
string ownerStr = (string)llGetOwner();
|
|
string objectStr = (string)llGetKey();
|
|
string combinedStr = ownerStr + objectStr;
|
|
|
|
// Create a more unique hash using both keys
|
|
string hashStr = llMD5String(combinedStr, 0);
|
|
integer hash1 = llSubStringIndex("0123456789abcdef", llGetSubString(hashStr, 0, 0));
|
|
integer hash2 = llSubStringIndex("0123456789abcdef", llGetSubString(hashStr, 1, 1));
|
|
integer combinedHash = hash1 * 16 + hash2; // Creates 0-255 range
|
|
|
|
return CHANNEL_BASE - (offset * 1000) - combinedHash;
|
|
}
|
|
|
|
// Dynamic channel variables
|
|
integer NUMBERPICK_CHANNEL;
|
|
|
|
// Channel initialization function
|
|
initializeChannels() {
|
|
NUMBERPICK_CHANNEL = calculateChannel(2); // ~-77200 range to match Main.lsl
|
|
|
|
// Report channel to owner for debugging
|
|
if (VERBOSE_LOGGING) {
|
|
llOwnerSay("🔧 [Number Picker Dialog] Dynamic channel initialized:");
|
|
llOwnerSay(" Number Pick: " + (string)NUMBERPICK_CHANNEL);
|
|
}
|
|
}
|
|
|
|
integer numberPickChannel; // Legacy variable, will be set dynamically
|
|
|
|
// Listen handle management
|
|
integer listenHandle = -1;
|
|
|
|
// Pagination and picking state
|
|
string currentPlayer = "";
|
|
key currentPlayerKey = NULL_KEY;
|
|
integer currentDiceType = 0;
|
|
integer picksNeeded = 1;
|
|
list currentPicks = [];
|
|
list globallyPickedNumbers = []; // Numbers already picked by other players
|
|
integer currentPage = 0;
|
|
integer NUMBERS_PER_PAGE = 9; // Leave room for navigation buttons
|
|
|
|
list getNumbersForPage(integer page, integer diceType) {
|
|
// Build list of available numbers (not picked by others OR by current player)
|
|
list availableNumbers = [];
|
|
integer i;
|
|
for (i = 1; i <= diceType; i++) {
|
|
string numStr = (string)i;
|
|
integer pickedByOthers = llListFindList(globallyPickedNumbers, [numStr]) != -1;
|
|
integer pickedByMe = llListFindList(currentPicks, [numStr]) != -1;
|
|
if (!pickedByOthers && !pickedByMe) {
|
|
availableNumbers += [numStr];
|
|
}
|
|
}
|
|
|
|
// Get the subset for this page
|
|
integer startIdx = page * NUMBERS_PER_PAGE;
|
|
integer endIdx = startIdx + NUMBERS_PER_PAGE - 1;
|
|
if (endIdx >= llGetListLength(availableNumbers)) {
|
|
endIdx = llGetListLength(availableNumbers) - 1;
|
|
}
|
|
|
|
list buttons = [];
|
|
for (i = startIdx; i <= endIdx && i < llGetListLength(availableNumbers); i++) {
|
|
buttons += [llList2String(availableNumbers, i)];
|
|
}
|
|
return buttons;
|
|
}
|
|
|
|
showPickDialog(string name, key id, integer diceType, integer picks) {
|
|
if (VERBOSE_LOGGING) {
|
|
llOwnerSay("📋 [NumberPicker] showPickDialog called for " + name + ", dice:" + (string)diceType + ", picks:" + (string)picks);
|
|
}
|
|
|
|
if (diceType <= 0) {
|
|
llOwnerSay("⚠️ Cannot show dialog: diceType is 0 or invalid.");
|
|
return;
|
|
}
|
|
|
|
// Initialize or update picking session
|
|
if (currentPlayer != name) {
|
|
if (VERBOSE_LOGGING) {
|
|
llOwnerSay("📋 [NumberPicker] Starting new session for " + name);
|
|
}
|
|
currentPlayer = name;
|
|
currentPlayerKey = id;
|
|
currentDiceType = diceType;
|
|
picksNeeded = picks;
|
|
currentPicks = [];
|
|
currentPage = 0;
|
|
} else {
|
|
if (VERBOSE_LOGGING) {
|
|
llOwnerSay("📋 [NumberPicker] Updating existing session for " + name);
|
|
}
|
|
}
|
|
|
|
list options;
|
|
integer totalPages = 1; // Default value
|
|
|
|
// If player has picked enough numbers, only show Done button
|
|
if (llGetListLength(currentPicks) >= picksNeeded) {
|
|
options = ["✅ Done"];
|
|
} else {
|
|
// Show number selection with pagination
|
|
options = getNumbersForPage(currentPage, diceType);
|
|
|
|
// If current page has no numbers, go back to page 0
|
|
if (llGetListLength(options) == 0 && currentPage > 0) {
|
|
currentPage = 0;
|
|
options = getNumbersForPage(currentPage, diceType);
|
|
}
|
|
|
|
// Calculate total pages based on available numbers, not all numbers
|
|
integer availableCount = diceType - llGetListLength(globallyPickedNumbers) - llGetListLength(currentPicks);
|
|
totalPages = (availableCount + NUMBERS_PER_PAGE - 1) / NUMBERS_PER_PAGE;
|
|
if (totalPages < 1) totalPages = 1;
|
|
|
|
// Only show navigation if there are multiple pages AND current page has numbers
|
|
if (totalPages > 1 && llGetListLength(options) > 0) {
|
|
if (currentPage > 0) options += ["◀ Prev"];
|
|
if (currentPage < totalPages - 1) options += ["Next ▶"];
|
|
}
|
|
}
|
|
|
|
string pickText = (string)picksNeeded;
|
|
if (picksNeeded == 1) pickText += " number";
|
|
else pickText += " numbers";
|
|
|
|
string pageInfo = "";
|
|
if (totalPages > 1) {
|
|
pageInfo = " (Page " + (string)(currentPage + 1) + "/" + (string)totalPages + ")";
|
|
}
|
|
|
|
string dialogText;
|
|
string currentPicksText = "";
|
|
if (llGetListLength(currentPicks) > 0) {
|
|
currentPicksText = "\nSelected: " + llList2CSV(currentPicks);
|
|
}
|
|
|
|
if (llGetListLength(currentPicks) >= picksNeeded) {
|
|
dialogText = "✅ You have picked enough numbers!" + currentPicksText + "\n\nClick Done to confirm your selection.";
|
|
} else {
|
|
dialogText = "Pick " + pickText + " (1-" + (string)diceType + ")" + pageInfo + currentPicksText;
|
|
}
|
|
|
|
if (VERBOSE_LOGGING) {
|
|
llOwnerSay("📋 [NumberPicker] About to show dialog to " + name + " (" + (string)id + ")");
|
|
llOwnerSay("📋 [NumberPicker] Dialog text: " + dialogText);
|
|
llOwnerSay("📋 [NumberPicker] Options (" + (string)llGetListLength(options) + "): " + llList2CSV(options));
|
|
llOwnerSay("📋 [NumberPicker] Channel: " + (string)numberPickChannel);
|
|
llOwnerSay("📋 [NumberPicker] globallyPickedNumbers: " + llList2CSV(globallyPickedNumbers));
|
|
}
|
|
|
|
llDialog(id, dialogText, options, numberPickChannel);
|
|
}
|
|
|
|
default {
|
|
state_entry() {
|
|
// Initialize dynamic channels
|
|
initializeChannels();
|
|
numberPickChannel = NUMBERPICK_CHANNEL; // Set legacy variable
|
|
|
|
// Clean up any existing listeners
|
|
if (listenHandle != -1) {
|
|
llListenRemove(listenHandle);
|
|
}
|
|
|
|
// Initialize/reset all dialog state
|
|
currentPlayer = "";
|
|
currentPlayerKey = NULL_KEY;
|
|
currentDiceType = 0;
|
|
picksNeeded = 1;
|
|
currentPicks = [];
|
|
globallyPickedNumbers = [];
|
|
currentPage = 0;
|
|
|
|
// Set up managed listener with dynamic channel
|
|
listenHandle = llListen(numberPickChannel, "", NULL_KEY, "");
|
|
llOwnerSay("🎮 Number Picker Dialog Handler ready!");
|
|
}
|
|
|
|
on_rez(integer start_param) {
|
|
if (VERBOSE_LOGGING) {
|
|
llOwnerSay("🔄 Number Picker rezzed - reinitializing...");
|
|
}
|
|
|
|
// Re-initialize dynamic channels
|
|
initializeChannels();
|
|
numberPickChannel = NUMBERPICK_CHANNEL;
|
|
|
|
// Clean up any existing listeners
|
|
if (listenHandle != -1) {
|
|
llListenRemove(listenHandle);
|
|
}
|
|
|
|
// Reset all dialog state variables
|
|
currentPlayer = "";
|
|
currentPlayerKey = NULL_KEY;
|
|
currentDiceType = 0;
|
|
picksNeeded = 1;
|
|
currentPicks = [];
|
|
globallyPickedNumbers = [];
|
|
currentPage = 0;
|
|
|
|
// Set up managed listener with dynamic channel
|
|
listenHandle = llListen(numberPickChannel, "", NULL_KEY, "");
|
|
if (VERBOSE_LOGGING) {
|
|
llOwnerSay("✅ Number Picker reset complete after rez!");
|
|
}
|
|
}
|
|
|
|
link_message(integer sender, integer num, string str, key id) {
|
|
// Handle verbose logging toggle
|
|
if (num == MSG_TOGGLE_VERBOSE_LOGS) {
|
|
VERBOSE_LOGGING = !VERBOSE_LOGGING;
|
|
if (VERBOSE_LOGGING) {
|
|
llOwnerSay("🔊 [NumberPicker] Verbose logging ENABLED");
|
|
} else {
|
|
llOwnerSay("🔊 [NumberPicker] Verbose logging DISABLED");
|
|
}
|
|
return;
|
|
}
|
|
|
|
// Handle dialog close command
|
|
if (num == -9999 && str == "CLOSE_ALL_DIALOGS") {
|
|
if (VERBOSE_LOGGING) {
|
|
llOwnerSay("🚫 [NumberPicker] CLOSE_ALL_DIALOGS received! currentPlayer: " + currentPlayer + ", key: " + (string)currentPlayerKey);
|
|
}
|
|
if (currentPlayerKey != NULL_KEY) {
|
|
if (VERBOSE_LOGGING) {
|
|
llOwnerSay("🚫 [NumberPicker] Forced dialog close for " + currentPlayer);
|
|
}
|
|
currentPlayer = "";
|
|
currentPlayerKey = NULL_KEY;
|
|
currentPicks = [];
|
|
} else {
|
|
if (VERBOSE_LOGGING) {
|
|
llOwnerSay("🚫 [NumberPicker] No active dialog to close");
|
|
}
|
|
}
|
|
return;
|
|
}
|
|
|
|
// Handle full reset from main controller
|
|
if (num == -99999 && str == "FULL_RESET") {
|
|
// Reset all dialog state
|
|
currentPlayer = "";
|
|
currentPlayerKey = NULL_KEY;
|
|
currentDiceType = 0;
|
|
picksNeeded = 1;
|
|
currentPicks = [];
|
|
globallyPickedNumbers = [];
|
|
currentPage = 0;
|
|
llOwnerSay("🎮 Number Picker Dialog Handler reset!");
|
|
return;
|
|
}
|
|
|
|
if (num == MSG_SHOW_DIALOG) {
|
|
list parts = llParseString2List(str, ["|"], []);
|
|
if (llGetListLength(parts) < 3) {
|
|
llOwnerSay("⚠️ Malformed MSG_SHOW_DIALOG input: " + str);
|
|
return;
|
|
}
|
|
|
|
string name = llList2String(parts, 0);
|
|
integer diceType = (integer)llList2String(parts, 1);
|
|
integer picks = (integer)llList2String(parts, 2);
|
|
|
|
// Get globally picked numbers if provided
|
|
if (llGetListLength(parts) >= 4) {
|
|
string globalPicksStr = llList2String(parts, 3);
|
|
if (globalPicksStr != "") {
|
|
// Handle both CSV (comma) and semicolon-separated formats
|
|
if (llSubStringIndex(globalPicksStr, ";") != -1) {
|
|
// Semicolon-separated format from bots
|
|
globallyPickedNumbers = llParseString2List(globalPicksStr, [";"], []);
|
|
} else {
|
|
// CSV format from humans
|
|
globallyPickedNumbers = llCSV2List(globalPicksStr);
|
|
}
|
|
} else {
|
|
globallyPickedNumbers = [];
|
|
}
|
|
} else {
|
|
globallyPickedNumbers = [];
|
|
}
|
|
|
|
showPickDialog(name, id, diceType, picks);
|
|
}
|
|
|
|
// Handle dialog recovery requests
|
|
else if (num == MSG_GET_CURRENT_DIALOG) {
|
|
string playerName = str;
|
|
// Only show dialog if this player is the current picker
|
|
if (currentPlayer == playerName && currentPlayerKey == id) {
|
|
if (VERBOSE_LOGGING) {
|
|
llOwnerSay("🔄 Restoring dialog for " + playerName);
|
|
}
|
|
showPickDialog(currentPlayer, currentPlayerKey, currentDiceType, picksNeeded);
|
|
} else {
|
|
llRegionSayTo(id, 0, "❌ You don't have an active dialog to restore.");
|
|
}
|
|
}
|
|
}
|
|
|
|
listen(integer channel, string name, key id, string message) {
|
|
// Ignore any responses if no active dialog session
|
|
if (currentPlayerKey == NULL_KEY || currentPlayer == "") {
|
|
if (VERBOSE_LOGGING) {
|
|
llOwnerSay("🚫 [NumberPicker] Ignoring stale dialog response (no active session). Player: " + name + ", Key: " + (string)id + ", Message: " + message);
|
|
}
|
|
return;
|
|
}
|
|
|
|
// Ignore responses from wrong player
|
|
if (id != currentPlayerKey) {
|
|
if (VERBOSE_LOGGING) {
|
|
llOwnerSay("🚫 [NumberPicker] Ignoring dialog response from wrong player. Expected: " + (string)currentPlayerKey + ", Got: " + (string)id + ", Message: " + message);
|
|
}
|
|
return;
|
|
}
|
|
|
|
// Additional validation: if this is a number selection, make sure it's still valid
|
|
integer messageNum = (integer)message;
|
|
if (messageNum > 0 && messageNum <= currentDiceType) {
|
|
// This looks like a number selection - verify it's not already globally picked
|
|
if (llListFindList(globallyPickedNumbers, [message]) != -1) {
|
|
if (VERBOSE_LOGGING) {
|
|
llOwnerSay("🚫 [NumberPicker] Ignoring stale dialog response - number " + message + " already globally picked. Player: " + name);
|
|
}
|
|
return;
|
|
}
|
|
|
|
// Also verify it's not already in current picks
|
|
if (llListFindList(currentPicks, [message]) != -1) {
|
|
if (VERBOSE_LOGGING) {
|
|
llOwnerSay("🚫 [NumberPicker] Ignoring stale dialog response - number " + message + " already in current picks. Player: " + name);
|
|
}
|
|
return;
|
|
}
|
|
}
|
|
|
|
// Handle navigation
|
|
if (message == "◀ Prev") {
|
|
if (currentPage > 0) {
|
|
currentPage--;
|
|
showPickDialog(currentPlayer, currentPlayerKey, currentDiceType, picksNeeded);
|
|
}
|
|
return;
|
|
}
|
|
if (message == "Next ▶") {
|
|
// Calculate total pages based on AVAILABLE numbers, not all dice numbers
|
|
integer availableCount = currentDiceType - llGetListLength(globallyPickedNumbers) - llGetListLength(currentPicks);
|
|
integer totalPages = (availableCount + NUMBERS_PER_PAGE - 1) / NUMBERS_PER_PAGE;
|
|
if (totalPages < 1) totalPages = 1;
|
|
|
|
if (currentPage < totalPages - 1) {
|
|
currentPage++;
|
|
showPickDialog(currentPlayer, currentPlayerKey, currentDiceType, picksNeeded);
|
|
}
|
|
return;
|
|
}
|
|
|
|
// Handle completion
|
|
if (message == "✅ Done") {
|
|
if (VERBOSE_LOGGING) {
|
|
llOwnerSay("📋 [NumberPicker] Done button clicked by " + name + ", currentPicks: " + llList2CSV(currentPicks) + ", needed: " + (string)picksNeeded);
|
|
}
|
|
if (llGetListLength(currentPicks) >= picksNeeded) {
|
|
string picksStr = llList2CSV(currentPicks);
|
|
string response = "HUMAN_PICKED:" + currentPlayer + ":" + picksStr;
|
|
if (VERBOSE_LOGGING) {
|
|
llOwnerSay("📤 [NumberPicker] SENDING HUMAN_PICKED: " + response);
|
|
}
|
|
llMessageLinked(LINK_SET, -9998, response, NULL_KEY);
|
|
// Reset state
|
|
if (VERBOSE_LOGGING) {
|
|
llOwnerSay("📋 [NumberPicker] Resetting session state for " + currentPlayer);
|
|
}
|
|
currentPlayer = "";
|
|
currentPlayerKey = NULL_KEY;
|
|
currentPicks = [];
|
|
} else {
|
|
if (VERBOSE_LOGGING) {
|
|
llOwnerSay("⚠️ " + currentPlayer + " needs " + (string)(picksNeeded - llGetListLength(currentPicks)) + " more picks");
|
|
}
|
|
showPickDialog(currentPlayer, currentPlayerKey, currentDiceType, picksNeeded);
|
|
}
|
|
return;
|
|
}
|
|
|
|
// Handle number selection
|
|
integer pickedNumber = (integer)message;
|
|
if (pickedNumber > 0 && pickedNumber <= currentDiceType) {
|
|
if (llGetListLength(currentPicks) < picksNeeded) {
|
|
// Add to picks (numbers already picked won't be shown in dialog)
|
|
currentPicks += [message];
|
|
} else {
|
|
llOwnerSay("⚠️ " + currentPlayer + " has already picked enough numbers");
|
|
}
|
|
|
|
// Show updated dialog
|
|
showPickDialog(currentPlayer, currentPlayerKey, currentDiceType, picksNeeded);
|
|
}
|
|
}
|
|
} |